Tegra186: secondary: fix MISRA defects

Main fixes:

Added explicit casts (e.g. 0U) to integers in order for them to be
compatible with whatever operation they're used in [Rule 10.1]

Force operands of an operator to the same type category [Rule 10.4]

Voided non c-library functions whose return types are not used [Rule 17.7]

Change-Id: I758e7ef6d45dd2edf4cd5580e2af15219246e75c
Signed-off-by: Anthony Zhou <[email protected]>

diff --git a/plat/nvidia/tegra/include/tegra_private.h b/plat/nvidia/tegra/include/tegra_private.h
index ff3d6d2cd8fda4a208f55a461fd6532ef9cb622c..d0028e01a9ebe80a89555d366f899c2b6b5bd90a 100644 (file)
--- a/plat/nvidia/tegra/include/tegra_private.h
+++ b/plat/nvidia/tegra/include/tegra_private.h
@@ -66,7 +66,7 @@ plat_params_from_bl2_t *plat_get_bl31_plat_params(void);
 
 /* Declarations for plat_secondary.c */
 void plat_secondary_setup(void);
-int plat_lock_cpu_vectors(void);
+int32_t plat_lock_cpu_vectors(void);
 
 /* Declarations for tegra_fiq_glue.c */
 void tegra_fiq_handler_setup(void);

diff --git a/plat/nvidia/tegra/soc/t186/plat_secondary.c b/plat/nvidia/tegra/soc/t186/plat_secondary.c
index 4485e2733a034a2c1eeb94ecf7d7c325ef17e276..35a403bc7d0dbe80c87204ee749f4c9521b0ac95 100644 (file)
--- a/plat/nvidia/tegra/soc/t186/plat_secondary.c
+++ b/plat/nvidia/tegra/soc/t186/plat_secondary.c
@@ -14,14 +14,13 @@
 #include <tegra_def.h>
 #include <tegra_private.h>
 
-#define MISCREG_CPU_RESET_VECTOR       0x2000
-#define MISCREG_AA64_RST_LOW           0x2004
-#define MISCREG_AA64_RST_HIGH          0x2008
+#define MISCREG_AA64_RST_LOW           0x2004U
+#define MISCREG_AA64_RST_HIGH          0x2008U
 
-#define SCRATCH_SECURE_RSV1_SCRATCH_0  0x658
-#define SCRATCH_SECURE_RSV1_SCRATCH_1  0x65C
+#define SCRATCH_SECURE_RSV1_SCRATCH_0  0x658U
+#define SCRATCH_SECURE_RSV1_SCRATCH_1  0x65CU
 
-#define CPU_RESET_MODE_AA64            1
+#define CPU_RESET_MODE_AA64            1U
 
 extern void memcpy16(void *dest, const void *src, unsigned int length);
 
@@ -34,7 +33,7 @@ extern uint64_t __tegra186_cpu_reset_handler_end;
 void plat_secondary_setup(void)
 {
        uint32_t addr_low, addr_high;
-       plat_params_from_bl2_t *params_from_bl2 = bl31_get_plat_params();
+       const plat_params_from_bl2_t *params_from_bl2 = bl31_get_plat_params();
        uint64_t cpu_reset_handler_base;
 
        INFO("Setting up secondary CPU boot\n");
@@ -58,7 +57,7 @@ void plat_secondary_setup(void)
        }
 
        addr_low = (uint32_t)cpu_reset_handler_base | CPU_RESET_MODE_AA64;
-       addr_high = (uint32_t)((cpu_reset_handler_base >> 32) & 0x7ff);
+       addr_high = (uint32_t)((cpu_reset_handler_base >> 32U) & 0x7ffU);
 
        /* write lower 32 bits first, then the upper 11 bits */
        mmio_write_32(TEGRA_MISC_BASE + MISCREG_AA64_RST_LOW, addr_low);
@@ -71,5 +70,5 @@ void plat_secondary_setup(void)
                        addr_high);
 
        /* update reset vector address to the CCPLEX */
-       mce_update_reset_vector();
+       (void)mce_update_reset_vector();
 }